multipathd crash on shutdown
authorHannes Reinecke <hare@suse.de>
Wed, 30 Apr 2008 09:03:24 +0000 (11:03 +0200)
committerChristophe Varoqui <christophe.varoqui@free.fr>
Wed, 30 Apr 2008 11:25:14 +0000 (13:25 +0200)
On shutdown multipathd flushes its internal message queue;
but we have to check if the messages on the queue are not empty.

Signed-off-by: Hannes Reinecke <hare@suse.de>
libmultipath/log_pthread.c

index d393ff4..8909440 100644 (file)
@@ -31,7 +31,8 @@ static void flush_logqueue (void)
                pthread_mutex_lock(logq_lock);
                empty = log_dequeue(la->buff);
                pthread_mutex_unlock(logq_lock);
-               log_syslog(la->buff);
+               if (!empty)
+                       log_syslog(la->buff);
        } while (empty == 0);
 }