panfrost: Remove stale TODO
authorAlyssa Rosenzweig <alyssa@collabora.com>
Tue, 7 Feb 2023 15:31:54 +0000 (10:31 -0500)
committerMarge Bot <emma+marge@anholt.net>
Thu, 23 Mar 2023 23:53:46 +0000 (23:53 +0000)
While the text here is still nominally accurate, we should be seeing so few
shader variants at this point that the locking contention isn't a big deal.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20906>

src/gallium/drivers/panfrost/pan_shader.c

index 3117747..8b3a52d 100644 (file)
@@ -319,9 +319,6 @@ panfrost_update_shader_variant(struct panfrost_context *ctx,
 
    ctx->prog[type] = compiled;
 
-   /* TODO: it would be more efficient to release the lock before
-    * compiling instead of after, but that can race if thread A compiles a
-    * variant while thread B searches for that same variant */
    simple_mtx_unlock(&uncompiled->lock);
 }