staging:rtl8192u: Remove SS_TH_low - Style
authorJohn Whitmore <johnfwhitmore@gmail.com>
Fri, 3 Aug 2018 00:02:01 +0000 (01:02 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 5 Aug 2018 14:21:06 +0000 (16:21 +0200)
The member variable SS_TH_low is assigned a constant and then used
in a comparison. This member variable is redundant as the constant
can be used directly for the comparison.

In addition the constant RxPathSelection_SS_TH_low has been renamed
to RX_PATH_SELECTION_SS_TH_LOW, to clear the checkpatch issue with
CamelCase naming.

These changes are coding style in nature and should not impact
runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/r8192U_dm.c
drivers/staging/rtl8192u/r8192U_dm.h

index 495f563879c878fad9a5ad8225332ae02a963b5f..f01d2f8d7fd238f0f2e0d1d0c32fd204f3aeceee 100644 (file)
@@ -2385,7 +2385,6 @@ static void dm_init_rxpath_selection(struct net_device *dev)
        u8 i;
        struct r8192_priv *priv = ieee80211_priv(dev);
 
-       DM_RxPathSelTable.SS_TH_low = RxPathSelection_SS_TH_low;
        DM_RxPathSelTable.diff_TH = RxPathSelection_diff_TH;
        if (priv->CustomerID == RT_CID_819x_Netcore)
                DM_RxPathSelTable.cck_method = CCK_RX_VERSION_2;
@@ -2555,7 +2554,7 @@ static void dm_rxpath_sel_byrssi(struct net_device *dev)
                        update_cck_rx_path = 1;
        }
 
-       if (tmp_min_rssi < DM_RxPathSelTable.SS_TH_low && disabled_rf_cnt < 2) {
+       if (tmp_min_rssi < RX_PATH_SELECTION_SS_TH_LOW && disabled_rf_cnt < 2) {
                if ((tmp_max_rssi - tmp_min_rssi) >= DM_RxPathSelTable.diff_TH) {
                        /* record the enabled rssi threshold */
                        DM_RxPathSelTable.rf_enable_rssi_th[min_rssi_index] = tmp_max_rssi+5;
index b1f19bad2c3021d9d97fb46f82b37a35af7d99d8..0aaac0fca1103670f390ce2eeeddee0002c61c08 100644 (file)
@@ -37,7 +37,7 @@
 #define                DM_DIG_MIN                                      0x1c
 #define                DM_DIG_MIN_Netcore                      0x12
 
-#define                RxPathSelection_SS_TH_low               30
+#define                RX_PATH_SELECTION_SS_TH_LOW             30
 #define                RxPathSelection_diff_TH                 18
 
 #define                RateAdaptiveTH_High                     50
@@ -132,7 +132,6 @@ struct dynamic_rx_path_sel {
        enum cck_rx_path_method         cck_method;
        u8              cck_rx_path;
 
-       u8              SS_TH_low;
        u8              diff_TH;
        u8              disabledRF;
        u8              reserved;