mm/kasan: switch from strlcpy to strscpy
authorZhiyuan Dai <daizhiyuan@phytium.com.cn>
Fri, 30 Apr 2021 05:59:43 +0000 (22:59 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 30 Apr 2021 18:20:41 +0000 (11:20 -0700)
strlcpy is marked as deprecated in Documentation/process/deprecated.rst,
and there is no functional difference when the caller expects truncation
(when not checking the return value).  strscpy is relatively better as it
also avoids scanning the whole source string.

Link: https://lkml.kernel.org/r/1613970647-23272-1-git-send-email-daizhiyuan@phytium.com.cn
Signed-off-by: Zhiyuan Dai <daizhiyuan@phytium.com.cn>
Acked-by: Alexander Potapenko <glider@google.com>
Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/kasan/report_generic.c

index de732bc..139615e 100644 (file)
@@ -148,7 +148,7 @@ static bool __must_check tokenize_frame_descr(const char **frame_descr,
                }
 
                /* Copy token (+ 1 byte for '\0'). */
-               strlcpy(token, *frame_descr, tok_len + 1);
+               strscpy(token, *frame_descr, tok_len + 1);
        }
 
        /* Advance frame_descr past separator. */