Fix GL errors expected for glClearNamedBufferData and glClearNamedBufferSubData
authorasokolow <aleksy.sokolowski@intel.com>
Thu, 20 Sep 2018 09:56:25 +0000 (11:56 +0200)
committerSlawomir Cygan <slawomir.cygan@intel.com>
Fri, 25 Jan 2019 11:15:57 +0000 (06:15 -0500)
The spec says:

"An INVALID_VALUE error is generated if type is not one of the types in
table 8.2.
An INVALID_VALUE error is generated if format is not one of the formats
in table 8.3."

However, the test was expecting INVALID_ENUM

Components: OpenGL

VK-GL-CTS Issue: 1572

Change-Id: Ibcb338061584af48026b291c4372303c083102ea
Affects: KHR-GL45.direct_state_access.buffers_errors

external/openglcts/modules/gl/gl4cDirectStateAccessBuffersTests.cpp

index a599a5e..7d1405e 100644 (file)
@@ -2761,7 +2761,7 @@ bool ErrorsTest::TestErrorsOfClearNamedBufferData()
                        m_pClearNamedBufferData(buffer, GL_R8, invalid_format, GL_UNSIGNED_BYTE, &dummy_data);
 
                        is_ok &= ErrorCheckAndLog(
-                               "glClearNamedBufferData", GL_INVALID_ENUM,
+                               "glClearNamedBufferData", GL_INVALID_VALUE,
                                " if format is not a valid format "
                                "(one of GL_RED, GL_RG, GL_RGB, GL_BGR, GL_RGBA, GL_BGRA, "
                                "GL_RED_INTEGER, GL_RG_INTEGER, GL_RGB_INTEGER, GL_BGR_INTEGER, GL_RGBA_INTEGER, GL_BGRA_INTEGER, "
@@ -2791,7 +2791,7 @@ bool ErrorsTest::TestErrorsOfClearNamedBufferData()
                        m_pClearNamedBufferData(buffer, GL_R8, GL_RED, invalid_type, &dummy_data);
 
                        is_ok &= ErrorCheckAndLog(
-                               "glClearNamedBufferData", GL_INVALID_ENUM,
+                               "glClearNamedBufferData", GL_INVALID_VALUE,
                                " if format is not a valid type "
                                "(one of GL_UNSIGNED_BYTE, GL_BYTE, GL_UNSIGNED_SHORT, "
                                "GL_SHORT, GL_UNSIGNED_INT, GL_INT, GL_FLOAT, GL_UNSIGNED_BYTE_3_3_2, "
@@ -3045,7 +3045,7 @@ bool ErrorsTest::TestErrorsOfClearNamedBufferSubData()
                                                                           &dummy_data);
 
                        is_ok &= ErrorCheckAndLog(
-                               "glClearNamedBufferSubData", GL_INVALID_ENUM,
+                               "glClearNamedBufferSubData", GL_INVALID_VALUE,
                                " if format is not a valid format "
                                "(one of GL_RED, GL_RG, GL_RGB, GL_BGR, GL_RGBA, GL_BGRA, "
                                "GL_RED_INTEGER, GL_RG_INTEGER, GL_RGB_INTEGER, GL_BGR_INTEGER, GL_RGBA_INTEGER, GL_BGRA_INTEGER, "
@@ -3075,7 +3075,7 @@ bool ErrorsTest::TestErrorsOfClearNamedBufferSubData()
                        m_pClearNamedBufferSubData(buffer, GL_R8, 0, sizeof(dummy_data), GL_RGBA, invalid_type, &dummy_data);
 
                        is_ok &= ErrorCheckAndLog(
-                               "glClearNamedBufferSubData", GL_INVALID_ENUM,
+                               "glClearNamedBufferSubData", GL_INVALID_VALUE,
                                " if format is not a valid type "
                                "(one of GL_UNSIGNED_BYTE, GL_BYTE, GL_UNSIGNED_SHORT, "
                                "GL_SHORT, GL_UNSIGNED_INT, GL_INT, GL_FLOAT, GL_UNSIGNED_BYTE_3_3_2, "