hwrng: xgene - Delete an error message in xgene_rng_probe()
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 4 Apr 2020 15:07:34 +0000 (17:07 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 16 Apr 2020 06:49:22 +0000 (16:49 +1000)
The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/xgene-rng.c

index d7516a4..008e6db 100644 (file)
@@ -328,10 +328,8 @@ static int xgene_rng_probe(struct platform_device *pdev)
                return PTR_ERR(ctx->csr_base);
 
        rc = platform_get_irq(pdev, 0);
-       if (rc < 0) {
-               dev_err(&pdev->dev, "No IRQ resource\n");
+       if (rc < 0)
                return rc;
-       }
        ctx->irq = rc;
 
        dev_dbg(&pdev->dev, "APM X-Gene RNG BASE %p ALARM IRQ %d",