video: Added event callback of RESIZE/MOVE for evas object at initial time. 39/209039/3
authorSeunghun Lee <shiin.lee@samsung.com>
Fri, 24 May 2019 04:50:04 +0000 (13:50 +0900)
committerSooChan Lim <sc1.lim@samsung.com>
Wed, 3 Jul 2019 08:34:29 +0000 (08:34 +0000)
There is no need to add these events in _e_video_hwc_render().
It's better to keep consistency unless it has specific reason.

Change-Id: Icc0e40b0882554b3346ed639700ba88722f9f559

src/bin/video/iface/e_video_hwc.c
src/bin/video/iface/e_video_hwc.h

index 635e884c2984b0baee2c62ba20213ad729c878be..de1ac375a0c6b15435deef04877c06d64b6fc8e7 100644 (file)
@@ -1326,14 +1326,6 @@ render_fail:
      e_comp_wl_video_buffer_unref(input_buffer);
 
 done:
-   if (!evh->cb_registered)
-     {
-        evas_object_event_callback_add(evh->ec->frame, EVAS_CALLBACK_RESIZE,
-                                       _e_video_hwc_cb_evas_resize, evh);
-        evas_object_event_callback_add(evh->ec->frame, EVAS_CALLBACK_MOVE,
-                                       _e_video_hwc_cb_evas_move, evh);
-        evh->cb_registered = EINA_TRUE;
-     }
    DBG("======================================.");
 }
 
@@ -1458,6 +1450,11 @@ _e_video_hwc_client_event_init(E_Video_Hwc *evh)
 {
    evas_object_event_callback_add(evh->ec->frame, EVAS_CALLBACK_SHOW,
                                   _e_video_hwc_cb_evas_show, evh);
+   evas_object_event_callback_add(evh->ec->frame, EVAS_CALLBACK_RESIZE,
+                                  _e_video_hwc_cb_evas_resize, evh);
+   evas_object_event_callback_add(evh->ec->frame, EVAS_CALLBACK_MOVE,
+                                  _e_video_hwc_cb_evas_move, evh);
+
    E_LIST_HANDLER_APPEND(evh->ec_event_handler, E_EVENT_CLIENT_SHOW,
                          _e_video_hwc_cb_client_show, evh);
    E_LIST_HANDLER_APPEND(evh->ec_event_handler, E_EVENT_CLIENT_BUFFER_CHANGE,
@@ -1469,6 +1466,10 @@ _e_video_hwc_client_event_deinit(E_Video_Hwc *evh)
 {
    evas_object_event_callback_del_full(evh->ec->frame, EVAS_CALLBACK_SHOW,
                                        _e_video_hwc_cb_evas_show, evh);
+   evas_object_event_callback_del_full(evh->ec->frame, EVAS_CALLBACK_RESIZE,
+                                       _e_video_hwc_cb_evas_resize, evh);
+   evas_object_event_callback_del_full(evh->ec->frame, EVAS_CALLBACK_MOVE,
+                                       _e_video_hwc_cb_evas_move, evh);
 
    E_FREE_LIST(evh->ec_event_handler, ecore_event_handler_del);
 }
@@ -1483,14 +1484,6 @@ _e_video_hwc_iface_destroy(E_Video_Comp_Iface *iface)
 
    _e_video_hwc_hide(evh);
 
-   if (evh->cb_registered)
-     {
-        evas_object_event_callback_del_full(evh->ec->frame, EVAS_CALLBACK_RESIZE,
-                                            _e_video_hwc_cb_evas_resize, evh);
-        evas_object_event_callback_del_full(evh->ec->frame, EVAS_CALLBACK_MOVE,
-                                            _e_video_hwc_cb_evas_move, evh);
-     }
-
    EINA_LIST_FOREACH_SAFE(evh->input_buffer_list, l, ll, vbuf)
      {
         e_comp_wl_video_buffer_set_use(vbuf, EINA_FALSE);
index 312694c97fd543166d512cb13aaafa34655dd1e5..11a669a8e2a192cec68fbcd8e6e0255c923f4d36 100644 (file)
@@ -91,7 +91,6 @@ struct _E_Video_Hwc
         Eina_Bool topmost_viewport;
      } render;
 
-   Eina_Bool  cb_registered;
    Eina_Bool  need_force_render;
 };