tipc: limit error messages relating to memory leak to one line
authorPaul Gortmaker <paul.gortmaker@windriver.com>
Wed, 11 Jul 2012 21:35:01 +0000 (17:35 -0400)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Thu, 12 Jul 2012 14:13:12 +0000 (10:13 -0400)
With the default name table size of 1024, it is possible that
the sanity check in tipc_nametbl_stop could spam out 1024
essentially identical error messages if memory was corrupted
or similar.  Limit it to issuing no more than a single message.

The actual chain number (i.e. 0 --> 1023) wouldn't provide any
useful insight if/when such an instance happened, so don't
bother printing out that value.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
net/tipc/name_table.c

index 13fb9d5..cade0ac 100644 (file)
@@ -940,8 +940,10 @@ void tipc_nametbl_stop(void)
        /* Verify name table is empty, then release it */
        write_lock_bh(&tipc_nametbl_lock);
        for (i = 0; i < tipc_nametbl_size; i++) {
-               if (!hlist_empty(&table.types[i]))
-                       err("tipc_nametbl_stop(): hash chain %u is non-null\n", i);
+               if (hlist_empty(&table.types[i]))
+                       continue;
+               err("tipc_nametbl_stop(): orphaned hash chain detected\n");
+               break;
        }
        kfree(table.types);
        table.types = NULL;