mctp/test: Update refcount checking in route fragment tests
authorJeremy Kerr <jk@codeconstruct.com.au>
Thu, 18 Nov 2021 06:57:23 +0000 (14:57 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 18 Nov 2021 12:01:14 +0000 (12:01 +0000)
In 99ce45d5e, we moved a route refcount decrement from
mctp_do_fragment_route into the caller. This invalidates the assumption
that the route test makes about refcount behaviour, so the route tests
fail.

This change fixes the test case to suit the new refcount behaviour.

Fixes: 99ce45d5e7db ("mctp: Implement extended addressing")
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mctp/test/route-test.c

index 36fac3daf86a4f9d65def0897bc7f0a84aa7dc98..86ad15abf8978a41d35f4107a75b4134111cb0b1 100644 (file)
@@ -150,11 +150,6 @@ static void mctp_test_fragment(struct kunit *test)
        rt = mctp_test_create_route(&init_net, NULL, 10, mtu);
        KUNIT_ASSERT_TRUE(test, rt);
 
-       /* The refcount would usually be incremented as part of a route lookup,
-        * but we're setting the route directly here.
-        */
-       refcount_inc(&rt->rt.refs);
-
        rc = mctp_do_fragment_route(&rt->rt, skb, mtu, MCTP_TAG_OWNER);
        KUNIT_EXPECT_FALSE(test, rc);