Fix memory leak from cynara_async_configuration_create 23/108023/2
authorRafal Krypa <r.krypa@samsung.com>
Mon, 2 Jan 2017 10:45:37 +0000 (11:45 +0100)
committerGerrit Code Review <gerrit@review.vlan103.tizen.org>
Mon, 2 Jan 2017 11:01:34 +0000 (03:01 -0800)
The previous patch has introduced a memory leak by always passing NULL
pointer to cynara_async_configuration_destroy instead of proper pointer.

Change-Id: I252e3c36b02e493f6cac6b4718edddb282d0c9eb
Signed-off-by: Rafal Krypa <r.krypa@samsung.com>
src/common/cynara.cpp

index 41f975a208e27686a7b35be7661296f45db5d651..3be57a71b4ff53ad2426bcbf34ae8c7581afe568 100644 (file)
@@ -691,9 +691,10 @@ Cynara::Cynara()
     pollFds[1].events = 0;
 
     cynara_async_configuration *p_conf = nullptr;
-    auto confPtr = makeUnique(p_conf, cynara_async_configuration_destroy);
     checkCynaraError(cynara_async_configuration_create(&p_conf),
                      "Cannot create cynara async configuration");
+    auto confPtr = makeUnique(p_conf, cynara_async_configuration_destroy);
+
     checkCynaraError(cynara_async_configuration_set_cache_size(p_conf, CACHE_SIZE),
             "Cannot set cynara async configuration cache size");
     checkCynaraError(