net-RDS: Delete an unnecessary check before the function call "module_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Thu, 2 Jul 2015 15:58:21 +0000 (17:58 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Jul 2015 16:27:42 +0000 (09:27 -0700)
The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rds/transport.c

index 8b4a6cd..83498e1 100644 (file)
@@ -73,7 +73,7 @@ EXPORT_SYMBOL_GPL(rds_trans_unregister);
 
 void rds_trans_put(struct rds_transport *trans)
 {
-       if (trans && trans->t_owner)
+       if (trans)
                module_put(trans->t_owner);
 }