media: i2c: et8ek8: simplify getting state container
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 21 Sep 2020 16:23:30 +0000 (18:23 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 16 Nov 2020 09:31:11 +0000 (10:31 +0100)
The pointer to 'struct v4l2_subdev' is stored in drvdata via
v4l2_i2c_subdev_init() so there is no point of a dance like:

    struct i2c_client *client = to_i2c_client(struct device *dev)
    struct v4l2_subdev *sd = i2c_get_clientdata(client);

This allows to remove local variable 'client' and few pointer
dereferences.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/et8ek8/et8ek8_driver.c

index 256acf7..122af76 100644 (file)
@@ -1237,7 +1237,7 @@ static ssize_t
 et8ek8_priv_mem_read(struct device *dev, struct device_attribute *attr,
                     char *buf)
 {
-       struct v4l2_subdev *subdev = i2c_get_clientdata(to_i2c_client(dev));
+       struct v4l2_subdev *subdev = dev_get_drvdata(dev);
        struct et8ek8_sensor *sensor = to_et8ek8_sensor(subdev);
 
 #if PAGE_SIZE < ET8EK8_PRIV_MEM_SIZE
@@ -1374,8 +1374,7 @@ static const struct v4l2_subdev_internal_ops et8ek8_internal_ops = {
  */
 static int __maybe_unused et8ek8_suspend(struct device *dev)
 {
-       struct i2c_client *client = to_i2c_client(dev);
-       struct v4l2_subdev *subdev = i2c_get_clientdata(client);
+       struct v4l2_subdev *subdev = dev_get_drvdata(dev);
        struct et8ek8_sensor *sensor = to_et8ek8_sensor(subdev);
 
        if (!sensor->power_count)
@@ -1386,8 +1385,7 @@ static int __maybe_unused et8ek8_suspend(struct device *dev)
 
 static int __maybe_unused et8ek8_resume(struct device *dev)
 {
-       struct i2c_client *client = to_i2c_client(dev);
-       struct v4l2_subdev *subdev = i2c_get_clientdata(client);
+       struct v4l2_subdev *subdev = dev_get_drvdata(dev);
        struct et8ek8_sensor *sensor = to_et8ek8_sensor(subdev);
 
        if (!sensor->power_count)