staging: r8188eu: remove the "dump tx packet" fragments
authorMartin Kaiser <martin@kaiser.cx>
Wed, 30 Mar 2022 20:12:10 +0000 (22:12 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 Apr 2022 05:33:48 +0000 (07:33 +0200)
Remove the code fragments for printing outgoing packets.

There's only a hal variable HAL_DEF_DBG_DUMP_TXPKT and the bDumpTxPkt
component of struct hal_data_8188e.

The hal variable is set by a private ioctl, it's never read.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220330201210.175941-3-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/usb_halinit.c
drivers/staging/r8188eu/include/hal_intf.h
drivers/staging/r8188eu/include/rtl8188e_hal.h
drivers/staging/r8188eu/os_dep/ioctl_linux.c

index 5c62061..8cb1163 100644 (file)
@@ -1338,9 +1338,6 @@ void GetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eVariab
        case HAL_DEF_DBG_DM_FUNC:
                *((u32 *)pValue) = haldata->odmpriv.SupportAbility;
                break;
-       case HAL_DEF_DBG_DUMP_TXPKT:
-               *((u8 *)pValue) = haldata->bDumpTxPkt;
-               break;
        default:
                break;
        }
@@ -1370,9 +1367,6 @@ void SetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eVariab
                        }
                }
                break;
-       case HAL_DEF_DBG_DUMP_TXPKT:
-               haldata->bDumpTxPkt = *((u8 *)pValue);
-               break;
        default:
                break;
        }
index 3ac8b2e..1e2177b 100644 (file)
@@ -41,7 +41,6 @@ enum hal_def_variable {
        HAL_DEF_IS_SUPPORT_ANT_DIV,
        HAL_DEF_CURRENT_ANTENNA,
        HAL_DEF_DBG_DM_FUNC,/* for dbg */
-       HAL_DEF_DBG_DUMP_TXPKT,
 };
 
 typedef s32 (*c2h_id_filter)(u8 id);
index 5bda353..d2a069d 100644 (file)
@@ -160,8 +160,6 @@ struct hal_data_8188e {
        u8      AntDivCfg;
        u8      TRxAntDivType;
 
-       u8      bDumpTxPkt;/* for debug */
-
        u8      OutEpQueueSel;
        u8      OutEpNumber;
 
index a45d60a..7df2138 100644 (file)
@@ -3632,10 +3632,6 @@ static int rtw_dbg_port(struct net_device *dev,
                        break;
                case 0x09:
                        break;
-               case 0x0c:/* dump rx/tx packet */
-                       if (arg == 1)
-                               SetHalDefVar8188EUsb(padapter, HAL_DEF_DBG_DUMP_TXPKT, &extra_arg);
-                       break;
                case 0x15:
                        break;
                case 0x10:/*  driver version display */