gst/gstinfo.c: Explain why we copy the list.

Original commit message from CVS:
* gst/gstinfo.c:
Explain why we copy the list.
* gst/gstpipeline.c:
Improve docs.
* gst/gstutils.c:
Add one debug-log statement to help tracing probelms with linking pads.

diff --git a/ChangeLog b/ChangeLog
index 108f03d..6cdf3e4 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2008-05-14  Stefan Kost  <ensonic@users.sf.net>
+
+       * gst/gstinfo.c:
+         Explain why we copy the list.
+
+       * gst/gstpipeline.c:
+         Improve docs.
+
+       * gst/gstutils.c:
+         Add one debug-log statement to help tracing probelms with linking pads.
+
 2008-05-12  Stefan Kost  <ensonic@users.sf.net>
 
        * tests/check/gst/gstinfo.c:

diff --git a/gst/gstinfo.c b/gst/gstinfo.c
index b928049..71c4664 100644 (file)
--- a/gst/gstinfo.c
+++ b/gst/gstinfo.c
@@ -799,6 +799,8 @@ gst_debug_remove_with_compare_func (GCompareFunc func, gpointer data)
   new = __log_functions;
   while ((found = g_slist_find_custom (new, data, func))) {
     if (new == __log_functions) {
+      /* make a copy when we have the first hit, so that we modify the copy and
+       * make that the new list later */
       new = g_slist_copy (new);
       continue;
     }

diff --git a/gst/gstpipeline.c b/gst/gstpipeline.c
index 3ce7edb..954957e 100644 (file)
--- a/gst/gstpipeline.c
+++ b/gst/gstpipeline.c
@@ -563,7 +563,7 @@ gst_pipeline_handle_message (GstBin * bin, GstMessage * message)
  * gst_pipeline_get_bus:
  * @pipeline: a #GstPipeline
  *
- * Gets the #GstBus of @pipeline.
+ * Gets the #GstBus of @pipeline. The bus allows applications to receive #GstMessages.
  *
  * Returns: a #GstBus, unref after usage.
  *

diff --git a/gst/gstutils.c b/gst/gstutils.c
index 2d243de..1ea3c59 100644 (file)
--- a/gst/gstutils.c
+++ b/gst/gstutils.c
@@ -959,6 +959,10 @@ gst_element_get_compatible_pad (GstElement * element, GstPad * pad,
   }
   gst_iterator_free (pads);
 
+  GST_CAT_DEBUG_OBJECT (GST_CAT_ELEMENT_PADS, element,
+      "Could not find a compatible unlinked always pad to link to %s:%s, now checking request pads",
+      GST_DEBUG_PAD_NAME (pad));
+
   /* try to create a new one */
   /* requesting is a little crazy, we need a template. Let's create one */
   templcaps = gst_pad_get_caps (pad);