ACPI: CPPC: Drop redundant local variable from cpc_read()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 12 Jan 2022 18:27:22 +0000 (19:27 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 17 Jan 2022 18:38:55 +0000 (19:38 +0100)
The ret_val local variable in cpc_read() is not necessary, so
eliminate it.

No functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Huang Rui <ray.huang@amd.com>
drivers/acpi/cppc_acpi.c

index 5bc5532..866560c 100644 (file)
@@ -915,14 +915,13 @@ int __weak cpc_write_ffh(int cpunum, struct cpc_reg *reg, u64 val)
 
 static int cpc_read(int cpu, struct cpc_register_resource *reg_res, u64 *val)
 {
-       int ret_val = 0;
        void __iomem *vaddr = NULL;
        int pcc_ss_id = per_cpu(cpu_pcc_subspace_idx, cpu);
        struct cpc_reg *reg = &reg_res->cpc_entry.reg;
 
        if (reg_res->type == ACPI_TYPE_INTEGER) {
                *val = reg_res->cpc_entry.int_value;
-               return ret_val;
+               return 0;
        }
 
        *val = 0;
@@ -968,10 +967,10 @@ static int cpc_read(int cpu, struct cpc_register_resource *reg_res, u64 *val)
        default:
                pr_debug("Error: Cannot read %u bit width from PCC for ss: %d\n",
                         reg->bit_width, pcc_ss_id);
-               ret_val = -EFAULT;
+               return -EFAULT;
        }
 
-       return ret_val;
+       return 0;
 }
 
 static int cpc_write(int cpu, struct cpc_register_resource *reg_res, u64 val)