gst/matroska/ebml-read.c: Even better would be if we actually did the right thing...

Original commit message from CVS:
* gst/matroska/ebml-read.c: (gst_ebml_read_sint):
Even better would be if we actually did the right thing
here (also, G_GUINT64_CONSTANT only exists since GLib-2.10).

diff --git a/ChangeLog b/ChangeLog
index 76a98ef5d0fe10272b468f14685fbe749436da6e..5e068b4f113e6904d817a2dec5164b3ccdb13377 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2006-04-09  Tim-Philipp Müller  <tim at centricular dot net>
+
+       * gst/matroska/ebml-read.c: (gst_ebml_read_sint):
+         Even better would be if we actually did the right thing
+         here (also, G_GUINT64_CONSTANT only exists since GLib-2.10).
+
 2006-04-08  Tim-Philipp Müller  <tim at centricular dot net>
 
        * gst/matroska/ebml-read.c: (gst_ebml_read_sint):

diff --git a/gst/matroska/ebml-read.c b/gst/matroska/ebml-read.c
index 10c3512353417ee7c8d6ac30adf283dd4ee5b10e..fd4a48993e58a420675e35ff40391ce93d446e38 100644 (file)
--- a/gst/matroska/ebml-read.c
+++ b/gst/matroska/ebml-read.c
@@ -507,7 +507,7 @@ gst_ebml_read_sint (GstEbmlRead * ebml, guint32 * id, gint64 * num)
 
   /* make signed */
   if (negative) {
-    *num = *num - (G_GUINT64_CONSTANT (1) << ((8 * size) - 1));
+    *num = 0 - *num;
   }
 
   gst_buffer_unref (buf);