ksmbd: Replace the ternary conditional operator with min()
authorLu Hongfei <luhongfei@vivo.com>
Fri, 9 Jun 2023 05:06:36 +0000 (13:06 +0800)
committerSteve French <stfrench@microsoft.com>
Mon, 26 Jun 2023 05:07:04 +0000 (00:07 -0500)
It would be better to replace the traditional ternary conditional
operator with min() in compare_sids.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/smbacl.c

index ad919a4..e5e438b 100644 (file)
@@ -97,7 +97,7 @@ int compare_sids(const struct smb_sid *ctsid, const struct smb_sid *cwsid)
        /* compare all of the subauth values if any */
        num_sat = ctsid->num_subauth;
        num_saw = cwsid->num_subauth;
-       num_subauth = num_sat < num_saw ? num_sat : num_saw;
+       num_subauth = min(num_sat, num_saw);
        if (num_subauth) {
                for (i = 0; i < num_subauth; ++i) {
                        if (ctsid->sub_auth[i] != cwsid->sub_auth[i]) {