gl/stereo: fix a coupld of caps leaks
authorMatthew Waters <matthew@centricular.com>
Thu, 3 Jun 2021 05:57:17 +0000 (15:57 +1000)
committerMatthew Waters <matthew@centricular.com>
Thu, 3 Jun 2021 05:58:38 +0000 (15:58 +1000)
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1187>

ext/gl/gstglstereomix.c
ext/gl/gstglstereosplit.c

index bb71a2c..061e209 100644 (file)
@@ -644,6 +644,7 @@ _negotiated_caps (GstAggregator * agg, GstCaps * caps)
       GST_GL_TEXTURE_TARGET_2D_STR, NULL);
 
   gst_gl_view_convert_set_caps (mix->viewconvert, in_caps, caps);
+  gst_caps_unref (in_caps);
 
   return TRUE;
 }
index 283e450..f39ec71 100644 (file)
@@ -808,6 +808,7 @@ stereosplit_sink_query (GstPad * pad, GstObject * parent, GstQuery * query)
     case GST_QUERY_CAPS:
     {
       GstCaps *filter, *left, *right, *combined, *ret, *templ_caps;
+      gboolean result;
 
       gst_query_parse_caps (query, &filter);
 
@@ -856,11 +857,14 @@ stereosplit_sink_query (GstPad * pad, GstObject * parent, GstQuery * query)
           gst_caps_intersect_full (combined, templ_caps,
           GST_CAPS_INTERSECT_FIRST);
       gst_caps_unref (templ_caps);
+      gst_caps_unref (combined);
 
       GST_LOG_OBJECT (split, "Returning sink pad caps %" GST_PTR_FORMAT, ret);
 
       gst_query_set_caps_result (query, ret);
-      return !gst_caps_is_empty (ret);
+      result = !gst_caps_is_empty (ret);
+      gst_caps_unref (ret);
+      return result;
     }
     default:
       return gst_pad_query_default (pad, parent, query);