Do not look at file symbols when reading psymtabs
authorTom Tromey <tom@tromey.com>
Tue, 22 May 2018 05:23:02 +0000 (23:23 -0600)
committerTom Tromey <tom@tromey.com>
Fri, 20 Jul 2018 15:42:45 +0000 (09:42 -0600)
The DWARF reader was setting the list_in_scope member when reading
partial symbols.  however, this member is only useful when reading
full symbols.  Future patches will make this assert, so remove these
unneeded initializations.

gdb/ChangeLog
2018-07-20  Tom Tromey  <tom@tromey.com>

* dwarf2read.c (process_psymtab_comp_unit_reader)
(build_type_psymtabs_reader): Do not set list_in_scope.

gdb/ChangeLog
gdb/dwarf2read.c

index f41f4e1..96b54fb 100644 (file)
@@ -1,5 +1,10 @@
 2018-07-20  Tom Tromey  <tom@tromey.com>
 
+       * dwarf2read.c (process_psymtab_comp_unit_reader)
+       (build_type_psymtabs_reader): Do not set list_in_scope.
+
+2018-07-20  Tom Tromey  <tom@tromey.com>
+
        * buildsym.c (free_pendings): Remove.
        (add_symbol_to_list, scoped_free_pendings)
        (finish_block_internal, buildsym_init): Update.
index e6a8a18..bdd1c9a 100644 (file)
@@ -7908,8 +7908,6 @@ process_psymtab_comp_unit_reader (const struct die_reader_specs *reader,
 
   prepare_one_comp_unit (cu, comp_unit_die, info->pretend_language);
 
-  cu->list_in_scope = &file_symbols;
-
   /* Allocate a new partial symbol table structure.  */
   filename = dwarf2_string_attr (comp_unit_die, DW_AT_name, cu);
   if (filename == NULL)
@@ -8077,7 +8075,6 @@ build_type_psymtabs_reader (const struct die_reader_specs *reader,
   VEC_safe_push (sig_type_ptr, tu_group->tus, sig_type);
 
   prepare_one_comp_unit (cu, type_unit_die, language_minimal);
-  cu->list_in_scope = &file_symbols;
   pst = create_partial_symtab (per_cu, "");
   pst->anonymous = 1;