ich9: call ich9_lpc_update_pic for disabled pirqs
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 17 Jun 2016 15:01:21 +0000 (17:01 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 29 Jun 2016 12:03:46 +0000 (14:03 +0200)
An asserted pirq can be disabled and the corresponding GSIs
should then go down to 0.  However, because of the conditional in
ich9_lpc_update_by_pirq, the legacy 8259 pin could remain stuck to 1.

Reviewed-by: Efimov Vasily <real@ispras.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/isa/lpc_ich9.c

index c1a4f1b34c1caa20cad0b8099d59510b812863f6..f7aed231e6468cb6c514680ac2e91236f3657f75 100644 (file)
@@ -234,9 +234,6 @@ static void ich9_lpc_update_by_pirq(ICH9LPCState *lpc, int pirq)
 
     ich9_lpc_pic_irq(lpc, pirq, &pic_irq, &pic_dis);
     assert(pic_irq < ICH9_LPC_PIC_NUM_PINS);
-    if (pic_dis) {
-        return;
-    }
 
     ich9_lpc_update_pic(lpc, pic_irq);
 }