alsa-sink: Avoid unloading alsa-sink module before calling try_recover()
authorZbigniew Kempczyński <z.kempczynsk@samsung.com>
Tue, 10 Nov 2015 06:51:46 +0000 (07:51 +0100)
committerArun Raghavan <git@arunraghavan.net>
Sat, 14 Nov 2015 04:20:34 +0000 (09:50 +0530)
This fixes rare condition when pulseaudio client tries to rewind,
but a device previously reached underrun and was changed to XRUN state.

src/modules/alsa/alsa-sink.c

index b6c7d09..476188c 100644 (file)
@@ -1628,8 +1628,10 @@ static int process_rewind(struct userdata *u) {
     pa_log_debug("Requested to rewind %lu bytes.", (unsigned long) rewind_nbytes);
 
     if (PA_UNLIKELY((unused = pa_alsa_safe_avail(u->pcm_handle, u->hwbuf_size, &u->sink->sample_spec)) < 0)) {
-        pa_log("snd_pcm_avail() failed: %s", pa_alsa_strerror((int) unused));
-        return -1;
+        if (try_recover(u, "snd_pcm_avail", (int) unused) < 0) {
+            pa_log_warn("Trying to recover from underrun failed during rewind");
+            return -1;
+        }
     }
 
     unused_nbytes = (size_t) unused * u->frame_size;