Disable CHECK_LOGGING with --release build

This commit introduces gn flag |tizen_release_build| and compile time
macro "TIZEN_RELEASE_BUILD" to disable the "ENABLE_CHECK_LOGGING"
feature in base/ directory.

Change-Id: I526015bac95261de8e25475bc5b1c87a457a00fa
Signed-off-by: Satyaveer Singh <satyaveer.s@samsung.com>

diff --git a/base/check.h b/base/check.h
index 36fb56a373a2c69779be64aa05d58a50ea6d64dc..edaa1fed33d73e2b9926f597c208bf2f64083d50 100644 (file)
--- a/base/check.h
+++ b/base/check.h
@@ -205,7 +205,7 @@ class BASE_EXPORT NotReachedNoreturnError : public CheckError {
 #error "Debug builds are not expected to be optimized as official builds."
 #endif  // defined(OFFICIAL_BUILD) && !defined(NDEBUG)
 
-#if BUILDFLAG(IS_TIZEN)
+#if !defined(TIZEN_RELEASE_BUILD)
 #define ENABLE_CHECK_LOGGING
 #endif
 

diff --git a/packaging/chromium-efl.spec b/packaging/chromium-efl.spec
index 8db2d2f0611f18d59ec4d645434537f5da8a9755..5bff75b8f3dd845d092082d3f27655e42a00d218 100644 (file)
--- a/packaging/chromium-efl.spec
+++ b/packaging/chromium-efl.spec
@@ -62,6 +62,12 @@ Source2: chromium-efl-engine.spec.in
 Source3: chromium-efl-browser.spec.in
 %endif
 
+%if "%{?_tizen_release_build}" == "1"
+%define __tizen_release_build 1
+%else
+%define __tizen_release_build 0
+%endif
+
 %if "%{?tizen_profile_name}" == "tv" && %{tizen_version} >= 70
 # Tizen TV 7.0
 %define __enable_capi_thread_booster 1
@@ -586,6 +592,7 @@ fi
 %else
   "use_system_icu=false" \
 %endif
+  "tizen_release_build=%{macro_to_bool _tizen_release_build}" \
   "build_chrome=%{macro_to_bool __build_chrome}" \
 %if "%{?tizen_profile_name}" == "tv"
   "lib_dir_path=\"%{_libdir}\"" \

diff --git a/tizen_src/build/common.sh b/tizen_src/build/common.sh
index cd8d8d0f7369a779a8cb8de8d4e7ca1cbcaab8af..64730e466eddc12251f2a8ce35a37e5b896b0001 100755 (executable)
--- a/tizen_src/build/common.sh
+++ b/tizen_src/build/common.sh
@@ -254,7 +254,7 @@ OPTIONS:
    --disable-chrome   Build chromium-efl without chrome browser
    --nodebug          Build -g0 option without debuginfo package
    --strip-all        Strip all symbols for chromium-efl rpm packages
-
+   --release          Build with release build flag to disable CHECK and NOTIMPLEMENTED
 examples:
 $0 --nodebug --strip-all
 EOF
@@ -388,6 +388,7 @@ function setupAndExecuteTargetBuild() {
 
   if [ "$RELEASE_BUILD" == "1" ]; then
     ARGS+=(--define "_local_build 0")
+    ARGS+=(--define "_tizen_release_build 1")
     if [[ $platform == "tv" ]]; then
       ARGS+=(--define "_clang 1")
     else

diff --git a/tizen_src/build/config/tizen_features.gni b/tizen_src/build/config/tizen_features.gni
index 695abeb45cf134ea1ad5fe5b7003ebda36ceaf3c..7161ab8aa7de689169688c0654926349f82d4304 100644 (file)
--- a/tizen_src/build/config/tizen_features.gni
+++ b/tizen_src/build/config/tizen_features.gni
@@ -63,6 +63,7 @@ declare_args() {
 
   tizen_atmos_decoder_enable = false
   tizen_pepper_extensions = false
+  tizen_release_build = false
 
   # Tizen multimedia related
   tizen_multimedia = false

diff --git a/tizen_src/chromium_impl/base/BUILD.gn b/tizen_src/chromium_impl/base/BUILD.gn
index 81331d9f0871297e79ab7189465b2290d6f6641d..cec8e566ca16c1b58244791001ea59a7a03c86a2 100644 (file)
--- a/tizen_src/chromium_impl/base/BUILD.gn
+++ b/tizen_src/chromium_impl/base/BUILD.gn
@@ -19,6 +19,9 @@ config("external_base_efl_config") {
       defines += [ "LIB_UPGRADE_ROOT_DIR=\"$lib_upgrade_root_dir\"",
       ]
     }
+    if (tizen_release_build) {
+      defines += [ "TIZEN_RELEASE_BUILD" ]
+    }
   } else {
     outdir = rebase_path("$root_out_dir")
     defines = [