pwm: sun4i: Narrow scope of local variable

The variable pval is only used in a single block in the function
sun4i_pwm_calculate(). So declare it in a more local scope to simplify
the function for humans and compilers.

While at it also simplify assignment to pval.

While the diffstat for this patch is negative for this patch I still
thing the advantage of having a narrower scope is beneficial.

In my compiler / .config setup (gcc 8.2.1, arm/imx_v6_v7_defconfig +
COMPILE_TEST + PWM_SUN4I) this change doesn't result in any binary
changes.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
index a573e9d..0decc7c 100644 (file)
--- a/drivers/pwm/pwm-sun4i.c
+++ b/drivers/pwm/pwm-sun4i.c
@@ -172,7 +172,7 @@ static int sun4i_pwm_calculate(struct sun4i_pwm_chip *sun4i_pwm,
                               bool *bypass)
 {
        u64 clk_rate, div = 0;
-       unsigned int pval, prescaler = 0;
+       unsigned int prescaler = 0;
 
        clk_rate = clk_get_rate(sun4i_pwm->clk);
 
@@ -203,9 +203,11 @@ static int sun4i_pwm_calculate(struct sun4i_pwm_chip *sun4i_pwm,
        if (prescaler == 0) {
                /* Go up from the first divider */
                for (prescaler = 0; prescaler < PWM_PRESCAL_MASK; prescaler++) {
-                       if (!prescaler_table[prescaler])
+                       unsigned int pval = prescaler_table[prescaler];
+
+                       if (!pval)
                                continue;
-                       pval = prescaler_table[prescaler];
+
                        div = clk_rate;
                        do_div(div, pval);
                        div = div * state->period;