ksmbd: send lease break notification on FILE_RENAME_INFORMATION
authorNamjae Jeon <linkinjeon@kernel.org>
Tue, 23 Jan 2024 11:40:30 +0000 (20:40 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 Feb 2024 00:18:58 +0000 (16:18 -0800)
[ Upstream commit 3fc74c65b367476874da5fe6f633398674b78e5a ]

Send lease break notification on FILE_RENAME_INFORMATION request.
This patch fix smb2.lease.v2_epoch2 test failure.

Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/smb/server/oplock.c
fs/smb/server/smb2pdu.c

index 3209ace..53dfaac 100644 (file)
@@ -541,14 +541,12 @@ static struct oplock_info *same_client_has_lease(struct ksmbd_inode *ci,
                                continue;
                        }
 
-                       if (lctx->req_state != lease->state)
-                               lease->epoch++;
-
                        /* upgrading lease */
                        if ((atomic_read(&ci->op_count) +
                             atomic_read(&ci->sop_count)) == 1) {
                                if (lease->state != SMB2_LEASE_NONE_LE &&
                                    lease->state == (lctx->req_state & lease->state)) {
+                                       lease->epoch++;
                                        lease->state |= lctx->req_state;
                                        if (lctx->req_state &
                                                SMB2_LEASE_WRITE_CACHING_LE)
@@ -559,13 +557,17 @@ static struct oplock_info *same_client_has_lease(struct ksmbd_inode *ci,
                                    atomic_read(&ci->sop_count)) > 1) {
                                if (lctx->req_state ==
                                    (SMB2_LEASE_READ_CACHING_LE |
-                                    SMB2_LEASE_HANDLE_CACHING_LE))
+                                    SMB2_LEASE_HANDLE_CACHING_LE)) {
+                                       lease->epoch++;
                                        lease->state = lctx->req_state;
+                               }
                        }
 
                        if (lctx->req_state && lease->state ==
-                           SMB2_LEASE_NONE_LE)
+                           SMB2_LEASE_NONE_LE) {
+                               lease->epoch++;
                                lease_none_upgrade(opinfo, lctx->req_state);
+                       }
                }
                read_lock(&ci->m_lock);
        }
index 8747fd3..6ddfe3f 100644 (file)
@@ -5581,6 +5581,7 @@ static int smb2_rename(struct ksmbd_work *work,
        if (!file_info->ReplaceIfExists)
                flags = RENAME_NOREPLACE;
 
+       smb_break_all_levII_oplock(work, fp, 0);
        rc = ksmbd_vfs_rename(work, &fp->filp->f_path, new_name, flags);
 out:
        kfree(new_name);