habanalabs: rephrase device out-of-memory message
authorOhad Sharabi <osharabi@habana.ai>
Tue, 22 Mar 2022 07:21:29 +0000 (09:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 22 May 2022 18:57:36 +0000 (20:57 +0200)
The out of memory message is rephrased to more subtle expression as out
of memory may be caused by the user in case of, for example, greedy
allocation.

In addition the user is also being notified by an error code.

Signed-off-by: Ohad Sharabi <osharabi@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/habanalabs/common/memory.c

index a438417..900f2f0 100644 (file)
@@ -117,7 +117,7 @@ static int alloc_device_memory(struct hl_ctx *ctx, struct hl_mem_in *args,
                        paddr = gen_pool_alloc(vm->dram_pg_pool, total_size);
                if (!paddr) {
                        dev_err(hdev->dev,
-                               "failed to allocate %llu contiguous pages with total size of %llu\n",
+                               "Cannot allocate %llu contiguous pages with total size of %llu\n",
                                num_pgs, total_size);
                        return -ENOMEM;
                }
@@ -156,9 +156,10 @@ static int alloc_device_memory(struct hl_ctx *ctx, struct hl_mem_in *args,
                        else
                                phys_pg_pack->pages[i] = gen_pool_alloc(vm->dram_pg_pool,
                                                                        page_size);
+
                        if (!phys_pg_pack->pages[i]) {
                                dev_err(hdev->dev,
-                                       "Failed to allocate device memory (out of memory)\n");
+                                       "Cannot allocate device memory (out of memory)\n");
                                rc = -ENOMEM;
                                goto page_err;
                        }