webrtc_sink_dump: Check return value of g_strdup_printf() 18/304418/1 accepted/tizen/unified/20240118.114138 accepted/tizen/unified/x/20240205.064001
authorSangchul Lee <sc11.lee@samsung.com>
Wed, 17 Jan 2024 06:57:51 +0000 (15:57 +0900)
committerSangchul Lee <sc11.lee@samsung.com>
Wed, 17 Jan 2024 06:58:07 +0000 (15:58 +0900)
[Version] 0.4.37
[Issue Type] Svace defect (DEREF_OF_NULL.RET.ALLOC)

Change-Id: I30166ee0e3661a9e3aab51cf9f845471ff1d15a4
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
packaging/capi-media-webrtc.spec
src/webrtc_sink_dump.c

index 735338160e7fa4a3938a3653aa8ff3d49e566d52..4b63b4ac15b09f5a4be40c63d76d3cc07583d00a 100644 (file)
@@ -1,6 +1,6 @@
 Name:       capi-media-webrtc
 Summary:    A WebRTC library in Tizen Native API
-Version:    0.4.36
+Version:    0.4.37
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
index fe0ade0f29424cb7880a8384af98bf2792f26dc7..b239bae7ab79cd6e736508abdbc24e44bfc65388 100644 (file)
@@ -49,6 +49,8 @@ GstPadProbeReturn _depayloaded_data_probe_cb(GstPad *pad, GstPadProbeInfo *info,
                sink->dump.path = g_strdup_printf("%s/webrtc-%p.sink%u.%s.%s.dump",
                        sink->webrtc->ini.general.dump_path, sink->webrtc, sink->id,
                        probe_data->av_idx == AV_IDX_AUDIO ? "audio" : "video", str_arr[1]);
+               RET_VAL_IF(sink->dump.path == NULL, GST_PAD_PROBE_REMOVE, "sink->dump.path is NULL");
+
                sink->dump.fp = fopen(sink->dump.path, "w");
                if (!sink->dump.fp) {
                        LOG_ERROR("failed to fopen() for %s, error:%s", sink->dump.path, g_strerror(errno));
@@ -130,4 +132,4 @@ void _remove_probe_from_pad_for_dump(webrtc_gst_slot_s *sink)
                }
        }
 }
-//LCOV_EXCL_STOP
\ No newline at end of file
+//LCOV_EXCL_STOP