media: sun4i-csi: Do not zero reserved fields
authorRicardo Ribalda <ribalda@chromium.org>
Tue, 12 Jan 2021 12:20:52 +0000 (13:20 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 27 Jan 2021 12:42:46 +0000 (13:42 +0100)
Core code already clears reserved fields of struct
v4l2_pix_format_mplane, check commit 4e1e0eb0e074 ("media: v4l2-ioctl: Zero
v4l2_plane_pix_format reserved fields").

Cc: Maxime Ripard <mripard@kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c

index 1a2f65d..4785fad 100644 (file)
@@ -113,8 +113,6 @@ static void _sun4i_csi_try_fmt(struct sun4i_csi *csi,
        pix->num_planes = _fmt->num_planes;
        pix->pixelformat = _fmt->fourcc;
 
-       memset(pix->reserved, 0, sizeof(pix->reserved));
-
        /* Align the width and height on the subsampling */
        width = ALIGN(pix->width, _fmt->hsub);
        height = ALIGN(pix->height, _fmt->vsub);
@@ -131,8 +129,6 @@ static void _sun4i_csi_try_fmt(struct sun4i_csi *csi,
                bpl = pix->width / hsub * _fmt->bpp[i] / 8;
                pix->plane_fmt[i].bytesperline = bpl;
                pix->plane_fmt[i].sizeimage = bpl * pix->height / vsub;
-               memset(pix->plane_fmt[i].reserved, 0,
-                      sizeof(pix->plane_fmt[i].reserved));
        }
 }