dmaengine: fsl-edma: move clearing of register interrupt into setup_irq function
authorFrank Li <Frank.Li@nxp.com>
Mon, 21 Aug 2023 16:16:13 +0000 (12:16 -0400)
committerVinod Koul <vkoul@kernel.org>
Tue, 22 Aug 2023 14:41:03 +0000 (20:11 +0530)
This accommodates differences in the register layout of EDMA v3 by moving
the clearing of register interrupts into the platform-specific set_irq
function. This should ensure better compatibility with EDMA v3.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20230821161617.2142561-9-Frank.Li@nxp.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/fsl-edma-main.c

index 7dfbdc8..111cfa2 100644 (file)
@@ -113,6 +113,8 @@ fsl_edma_irq_init(struct platform_device *pdev, struct fsl_edma_engine *fsl_edma
 {
        int ret;
 
+       edma_writel(fsl_edma, ~0, fsl_edma->regs.intl);
+
        fsl_edma->txirq = platform_get_irq_byname(pdev, "edma-tx");
        if (fsl_edma->txirq < 0)
                return fsl_edma->txirq;
@@ -154,6 +156,8 @@ fsl_edma2_irq_init(struct platform_device *pdev,
        int i, ret, irq;
        int count;
 
+       edma_writel(fsl_edma, ~0, fsl_edma->regs.intl);
+
        count = platform_irq_count(pdev);
        dev_dbg(&pdev->dev, "%s Found %d interrupts\r\n", __func__, count);
        if (count <= 2) {
@@ -321,7 +325,6 @@ static int fsl_edma_probe(struct platform_device *pdev)
                fsl_edma_chan_mux(fsl_chan, 0, false);
        }
 
-       edma_writel(fsl_edma, ~0, regs->intl);
        ret = fsl_edma->drvdata->setup_irq(pdev, fsl_edma);
        if (ret)
                return ret;