IB/hfi1: Reduce printing of errors during driver shut down
authorDouglas Miller <doug.miller@cornelisnetworks.com>
Tue, 22 Aug 2023 14:07:58 +0000 (10:07 -0400)
committerLeon Romanovsky <leon@kernel.org>
Tue, 22 Aug 2023 14:31:45 +0000 (17:31 +0300)
The driver prints unnecessary prints for error conditions on shutdown
remove them to quiet it down.

Signed-off-by: Douglas Miller <doug.miller@cornelisnetworks.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Link: https://lore.kernel.org/r/169271327832.1855761.3756156924805531643.stgit@awfm-02.cornelisnetworks.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/hfi1/chip.c

index 9dbb89e..e954af8 100644 (file)
@@ -1461,7 +1461,8 @@ static u64 dc_access_lcb_cntr(const struct cntr_entry *entry, void *context,
                ret = write_lcb_csr(dd, csr, data);
 
        if (ret) {
-               dd_dev_err(dd, "Could not acquire LCB for counter 0x%x", csr);
+               if (!(dd->flags & HFI1_SHUTDOWN))
+                       dd_dev_err(dd, "Could not acquire LCB for counter 0x%x", csr);
                return 0;
        }
 
@@ -6160,7 +6161,7 @@ static int request_host_lcb_access(struct hfi1_devdata *dd)
        ret = do_8051_command(dd, HCMD_MISC,
                              (u64)HCMD_MISC_REQUEST_LCB_ACCESS <<
                              LOAD_DATA_FIELD_ID_SHIFT, NULL);
-       if (ret != HCMD_SUCCESS) {
+       if (ret != HCMD_SUCCESS && !(dd->flags & HFI1_SHUTDOWN)) {
                dd_dev_err(dd, "%s: command failed with error %d\n",
                           __func__, ret);
        }
@@ -6241,7 +6242,8 @@ int acquire_lcb_access(struct hfi1_devdata *dd, int sleep_ok)
        if (dd->lcb_access_count == 0) {
                ret = request_host_lcb_access(dd);
                if (ret) {
-                       dd_dev_err(dd,
+                       if (!(dd->flags & HFI1_SHUTDOWN))
+                               dd_dev_err(dd,
                                   "%s: unable to acquire LCB access, err %d\n",
                                   __func__, ret);
                        goto done;