llvmpipe: Handle NULL views in llvmpipe_cleanup_stage_sampling
authorJoshua Ashton <joshua@froggi.es>
Tue, 13 Jul 2021 21:09:24 +0000 (22:09 +0100)
committerMarge Bot <eric+marge@anholt.net>
Wed, 14 Jul 2021 02:50:30 +0000 (02:50 +0000)
This is the only barrier to lavapipe fully working in RenderDoc.

Fixes: 21864bdaaef6 ("llvmpipe: unmap display target of shader image/sampler")

Signed-off-by: Joshua Ashton <joshua@froggi.es>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11856>

src/gallium/drivers/llvmpipe/lp_state_sampler.c

index c631d11..9303e3b 100644 (file)
@@ -422,10 +422,11 @@ llvmpipe_cleanup_stage_sampling(struct llvmpipe_context *ctx,
 
    for (i = 0; i < num; i++) {
       struct pipe_sampler_view *view = views[i];
-      assert(view);
-      struct pipe_resource *tex = view->texture;
-      if (tex)
-         llvmpipe_resource_unmap(tex, 0, 0);
+      if (view) {
+         struct pipe_resource *tex = view->texture;
+         if (tex)
+            llvmpipe_resource_unmap(tex, 0, 0);
+      }
    }
 }