projects
/
platform
/
kernel
/
u-boot.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a9d9d41
)
mtd: spi-nor-core: Check return value of write_disable() in spi_nor_erase()
author
Marek Behún
<marek.behun@nic.cz>
Tue, 5 Oct 2021 13:56:00 +0000
(15:56 +0200)
committer
Jagan Teki
<jagan@amarulasolutions.com>
Sat, 23 Oct 2021 10:17:33 +0000
(15:47 +0530)
The cleanup code of spi_nor_erase() function calls write_disable(), but
does not return it's return value even in case of failure. Fix this.
Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
drivers/mtd/spi/spi-nor-core.c
patch
|
blob
|
history
diff --git
a/drivers/mtd/spi/spi-nor-core.c
b/drivers/mtd/spi/spi-nor-core.c
index
d8eed59
..
30c54cd
100644
(file)
--- a/
drivers/mtd/spi/spi-nor-core.c
+++ b/
drivers/mtd/spi/spi-nor-core.c
@@
-953,7
+953,9
@@
erase_err:
if (!ret)
ret = err;
#endif
- write_disable(nor);
+ err = write_disable(nor);
+ if (!ret)
+ ret = err;
return ret;
}