[SCSI] lpfc: force retry in queuecommand when port is transitioning
authorMike Christie <michaelc@cs.wisc.edu>
Fri, 25 Feb 2011 20:04:27 +0000 (14:04 -0600)
committerJames Bottomley <James.Bottomley@suse.de>
Mon, 28 Feb 2011 17:17:44 +0000 (11:17 -0600)
If the port takes a while to transition we could exhaust
the retries when using DID_TRANSPORT_DISRUPTED. For this
case we do not want to use any of the cmd's
retries, because if the command was running then when
it got failed the retry counter was already incremented.
And if this is the first time we are seeing the command,
(it got queued because it slipped through during the race)
then it should not have its retries incremented. The
fc class will decide the correct handling later.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Acked-by: James Smart <james.smart@emulex.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/lpfc/lpfc_scsi.c

index 1255b9d..ff20abd 100644 (file)
@@ -3058,7 +3058,7 @@ lpfc_queuecommand_lck(struct scsi_cmnd *cmnd, void (*done) (struct scsi_cmnd *))
         * transport is still transitioning.
         */
        if (!ndlp || !NLP_CHK_NODE_ACT(ndlp)) {
-               cmnd->result = ScsiResult(DID_TRANSPORT_DISRUPTED, 0);
+               cmnd->result = ScsiResult(DID_IMM_RETRY, 0);
                goto out_fail_command;
        }
        if (atomic_read(&ndlp->cmd_pending) >= ndlp->cmd_qdepth)