watchdog: sp5100_tco: Fix watchdog disable bit
authorGuenter Roeck <linux@roeck-us.net>
Sun, 24 Dec 2017 21:04:07 +0000 (13:04 -0800)
committerWim Van Sebroeck <wim@iguana.be>
Sun, 21 Jan 2018 11:56:34 +0000 (12:56 +0100)
According to all published information, the watchdog disable bit for SB800
compatible controllers is bit 1 of PM register 0x48, not bit 2. For the
most part that doesn't matter in practice, since the bit has to be cleared
to enable watchdog address decoding, which is the default setting, but it
still needs to be fixed.

Cc: Zoltán Böszörményi <zboszor@pr.hu>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/sp5100_tco.h

index f495fe0..2622cfe 100644 (file)
@@ -52,7 +52,7 @@
 #define SB800_PM_WATCHDOG_CONFIG       0x4C
 
 #define SB800_PCI_WATCHDOG_DECODE_EN   (1 << 0)
-#define SB800_PM_WATCHDOG_DISABLE      (1 << 2)
+#define SB800_PM_WATCHDOG_DISABLE      (1 << 1)
 #define SB800_PM_WATCHDOG_SECOND_RES   (3 << 0)
 #define SB800_ACPI_MMIO_DECODE_EN      (1 << 0)
 #define SB800_ACPI_MMIO_SEL            (1 << 1)