HID: uclogic: Use KUNIT_EXPECT_MEMEQ
authorJosé Expósito <jose.exposito89@gmail.com>
Mon, 26 Dec 2022 12:57:36 +0000 (13:57 +0100)
committerJiri Kosina <jkosina@suse.cz>
Wed, 18 Jan 2023 08:47:04 +0000 (09:47 +0100)
Commit b8a926bea8b1 ("kunit: Introduce KUNIT_EXPECT_MEMEQ and
KUNIT_EXPECT_MEMNEQ macros") introduced a new macro to compare blocks of
memory and, if the test fails, print the result in a human friendly
format. For example, this is the output of a test failure:

 Expected res == params->expected, but
     res ==
      01  02  aa  00  00  00  03  bb  00 <00> 00  04  05
     params->expected ==
      01  02  aa  00  00  00  03  bb  00 <01> 00  04  05

Use this new macro to replace KUNIT_EXPECT_EQ + memcmp.

Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Reviewed-by: Maíra Canal <mairacanal@riseup.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-uclogic-rdesc-test.c

index b429c54..90bf4e5 100644 (file)
@@ -197,8 +197,7 @@ static void hid_test_uclogic_template(struct kunit *test)
                                           params->param_list,
                                           params->param_num);
        KUNIT_ASSERT_NOT_ERR_OR_NULL(test, res);
-       KUNIT_EXPECT_EQ(test, 0,
-                       memcmp(res, params->expected, params->template_size));
+       KUNIT_EXPECT_MEMEQ(test, res, params->expected, params->template_size);
        kfree(res);
 }