[ThinLTO] Clear dllimport when setting dso_local.

This is PR36686.

If a user of a library is LTOed with that library we take the
opportunity to set dso_local, but we don't clear dllimport, which
creates an invalid IR.

llvm-svn: 327408

diff --git a/llvm/lib/Transforms/Utils/FunctionImportUtils.cpp b/llvm/lib/Transforms/Utils/FunctionImportUtils.cpp
index bf6cce9..479816a 100644 (file)
--- a/llvm/lib/Transforms/Utils/FunctionImportUtils.cpp
+++ b/llvm/lib/Transforms/Utils/FunctionImportUtils.cpp
@@ -206,8 +206,11 @@ void FunctionImportGlobalProcessing::processGlobalForThinLTO(GlobalValue &GV) {
   // definition.
   if (GV.hasName()) {
     ValueInfo VI = ImportIndex.getValueInfo(GV.getGUID());
-    if (VI && VI.isDSOLocal())
+    if (VI && VI.isDSOLocal()) {
       GV.setDSOLocal(true);
+      if (GV.hasDLLImportStorageClass())
+        GV.setDLLStorageClass(GlobalValue::DefaultStorageClass);
+    }
   }
 
   bool DoPromote = false;

diff --git a/llvm/test/ThinLTO/X86/Inputs/dsolocal_dllimport.ll b/llvm/test/ThinLTO/X86/Inputs/dsolocal_dllimport.ll
new file mode 100644 (file)
index 0000000..5e08d98
--- /dev/null
+++ b/llvm/test/ThinLTO/X86/Inputs/dsolocal_dllimport.ll
@@ -0,0 +1,5 @@
+target datalayout = "e-m:w-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-pc-windows-msvc19.11.0"
+define dso_local dllexport i32 @foo() {
+  ret i32 42
+}

diff --git a/llvm/test/ThinLTO/X86/dsolocal_dllimport.ll b/llvm/test/ThinLTO/X86/dsolocal_dllimport.ll
new file mode 100644 (file)
index 0000000..12f097f
--- /dev/null
+++ b/llvm/test/ThinLTO/X86/dsolocal_dllimport.ll
@@ -0,0 +1,16 @@
+; RUN: opt -module-summary %s -o %t1.bc
+; RUN: opt -module-summary %S/Inputs/dsolocal_dllimport.ll -o %t2.bc
+; RUN: llvm-lto2 run %t1.bc %t2.bc -o %t -r=%t1.bc,bar,px -r=%t1.bc,__imp_foo, -r=%t2.bc,foo -save-temps
+; RUN: llvm-dis < %t.1.3.import.bc | FileCheck %s
+
+; If a user (dllimport) is LTOed with a library, check that we replace dllimport with dso_local.
+
+; CHECK: declare dso_local void @foo()
+
+target datalayout = "e-m:w-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-pc-windows-msvc19.11.0"
+define void @bar() {
+  call void @foo()
+  ret void
+}
+declare dllimport void @foo()