Remove useless logic

Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>

diff --git a/parser/src/pkgmgr_parser_db.c b/parser/src/pkgmgr_parser_db.c
index d1ce42b..2a79eb4 100644 (file)
--- a/parser/src/pkgmgr_parser_db.c
+++ b/parser/src/pkgmgr_parser_db.c
@@ -1653,7 +1653,6 @@ static int __insert_package_privilege_info(sqlite3 *db, manifest_x *mfx)
 static int __insert_package_plugin_execution_info(
                manifest_x *mfx, uid_t uid)
 {
-       char *query = NULL;
        GList *tmp;
        plugin_x *plugin;
        char **queries = NULL;
@@ -1674,34 +1673,33 @@ static int __insert_package_plugin_execution_info(
                if (plugin == NULL)
                        continue;
 
-               query = sqlite3_mprintf("INSERT INTO package_plugin_info "
+               queries[idx] = sqlite3_mprintf("INSERT INTO package_plugin_info "
                                "(pkgid, appid, plugin_type, plugin_name) "
                                "VALUES (%Q, %Q, %Q, %Q)",
                                plugin->pkgid, plugin->appid,
                                plugin->plugin_type, plugin->plugin_name);
-               if (query == NULL) {
+               if (queries[idx] == NULL) {
                        _LOGE("Out of memory");
                        for (i = 0; i < idx; ++i)
-                               free(queries[i]);
+                               sqlite3_free(queries[i]);
                        free(queries);
                        return PM_PARSER_R_ERROR;
                }
 
-               queries[idx++] = query;
+               idx++;
        }
 
        if (_parser_execute_write_queries((const char **)queries, idx, uid) < 0) {
                _LOGE("Fail to write to db");
                for (i = 0; i < idx; ++i)
-                       free(queries[i]);
+                       sqlite3_free(queries[i]);
                free(queries);
                return PM_PARSER_R_ERROR;
        }
 
        for (i = 0; i < idx; ++i)
-               free(queries[i]);
+               sqlite3_free(queries[i]);
        free(queries);
-       free(query);
 
        return PM_PARSER_R_OK;
 }