media: s3c-camif: use semicolons rather than commas to separate statements
authorJulia Lawall <Julia.Lawall@inria.fr>
Tue, 29 Sep 2020 13:14:30 +0000 (15:14 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 16 Nov 2020 09:31:06 +0000 (10:31 +0100)
Replace commas with semicolons.  Commas introduce unnecessary
variability in the code structure and are hard to see.  What is done
is essentially described by the following Coccinelle semantic patch
(http://coccinelle.lip6.fr/):

// <smpl>
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/s3c-camif/camif-core.c

index 422fd54..4c3c00d 100644 (file)
@@ -131,11 +131,13 @@ static int camif_get_scaler_factor(u32 src, u32 tar, u32 *ratio, u32 *shift)
        while (sh--) {
                unsigned int tmp = 1 << sh;
                if (src >= tar * tmp) {
-                       *shift = sh, *ratio = tmp;
+                       *shift = sh;
+                       *ratio = tmp;
                        return 0;
                }
        }
-       *shift = 0, *ratio = 1;
+       *shift = 0;
+       *ratio = 1;
        return 0;
 }