sound: Remove set_theme_id() from id initialization 94/308494/1 accepted/tizen/unified/20240327.141644 accepted/tizen/unified/x/20240401.142435
authorYunhee Seo <yuni.seo@samsung.com>
Tue, 20 Feb 2024 02:43:13 +0000 (11:43 +0900)
committerChanwoo Choi <cw00.choi@samsung.com>
Tue, 26 Mar 2024 09:52:04 +0000 (18:52 +0900)
When the sound current_theme_id is initialized,
there is no need to call sound_set_theme_id().
Because sound_set_theme_id() calls vconf_set_int(),
this requires privilege "http://tizen.org/privilege/systemsettings.admin" when it call for
VCONFKEY_SETAPPL_ACCESSIBILITY_SOUND_FEEDBACK_THEME.
That makes all apps have that privilege during sound init process.
Thus, this function usage is removed.

Current theme id policy is as follows.

1. If there is a set vconf value, current theme id follows that value.
2. It there is no set vconf value, current theme id will be default theme id by sound conf parsing.

Change-Id: Ie526151a993006793902bb502f915d8b94c996b3
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
src/sound.c

index 02bfbb7..5a67eef 100644 (file)
@@ -163,7 +163,7 @@ static void sound_theme_id_init(void)
        if (ret < 0 || theme_id == SOUND_THEME_ID_UNINITIALIZED)
                sound_thememan_get_default_sound_theme_id(&theme_id);
 
-       sound_set_theme_id(theme_id);
+       current_theme_id = theme_id;
 }
 
 static void sound_init(void)