projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
aed361a
)
remoteproc: qcom: wcnss: Fix return value check in wcnss_probe()
author
Wei Yongjun
<weiyongjun1@huawei.com>
Sun, 21 Aug 2016 14:39:30 +0000
(14:39 +0000)
committer
Bjorn Andersson
<bjorn.andersson@linaro.org>
Tue, 23 Aug 2016 04:36:43 +0000
(21:36 -0700)
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/qcom_wcnss.c
patch
|
blob
|
history
diff --git
a/drivers/remoteproc/qcom_wcnss.c
b/drivers/remoteproc/qcom_wcnss.c
index
14c4585
..
1917de7
100644
(file)
--- a/
drivers/remoteproc/qcom_wcnss.c
+++ b/
drivers/remoteproc/qcom_wcnss.c
@@
-528,8
+528,8
@@
static int wcnss_probe(struct platform_device *pdev)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pmu");
mmio = devm_ioremap_resource(&pdev->dev, res);
- if (
!mmio
) {
- ret =
-ENOMEM
;
+ if (
IS_ERR(mmio)
) {
+ ret =
PTR_ERR(mmio)
;
goto free_rproc;
};