ASoC: ti: davinci-mcasp: remove redundant assignment to variable ret
authorColin Ian King <colin.king@canonical.com>
Mon, 10 Feb 2020 09:24:22 +0000 (09:24 +0000)
committerMark Brown <broonie@kernel.org>
Tue, 11 Feb 2020 11:47:59 +0000 (11:47 +0000)
The assignment to ret is redundant as it is not used in the error
return path and hence can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20200210092423.327499-1-colin.king@canonical.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/ti/davinci-mcasp.c

index d9c3a32..734ffe9 100644 (file)
@@ -1765,10 +1765,8 @@ static struct davinci_mcasp_pdata *davinci_mcasp_set_pdata_from_of(
        } else if (match) {
                pdata = devm_kmemdup(&pdev->dev, match->data, sizeof(*pdata),
                                     GFP_KERNEL);
-               if (!pdata) {
-                       ret = -ENOMEM;
-                       return pdata;
-               }
+               if (!pdata)
+                       return NULL;
        } else {
                /* control shouldn't reach here. something is wrong */
                ret = -EINVAL;