Fix auto to const auto &

[Version] 0.28.8
[Issue] coverity

Coverity report major defect auto_causes_copy.

Change-Id: I5fe928d8a95572f26ddd0f299299a45a2c043732
Signed-off-by: Kwanghoon Son <k.son@samsung.com>

diff --git a/mv_machine_learning/inference/src/BvhParser.cpp b/mv_machine_learning/inference/src/BvhParser.cpp
index 317c5294cdaead4388aaf8c82739785ad59065c2..9f7431ed007940bf9fcc9213c8ce21c921cfaf70 100644 (file)
--- a/mv_machine_learning/inference/src/BvhParser.cpp
+++ b/mv_machine_learning/inference/src/BvhParser.cpp
@@ -331,7 +331,7 @@ int BvhParser::parse_motion(std::ifstream &file)
 
                float number;
                for (int i = 0; i < frames_num; i++) {
-                       for (auto joint : bvh_->joints()) {
+                       for (const auto &joint : bvh_->joints()) {
                                std::vector<float> data;
                                for (unsigned j = 0; j < joint->num_channels(); j++) {
                                        file >> number;

diff --git a/packaging/capi-media-vision.spec b/packaging/capi-media-vision.spec
index 9940c30a76be255ea55863db346081e187481595..6688b1fa6aa91b79b959553821ef1bcfc4b5127c 100644 (file)
--- a/packaging/capi-media-vision.spec
+++ b/packaging/capi-media-vision.spec
@@ -1,6 +1,6 @@
 Name:        capi-media-vision
 Summary:     Media Vision library for Tizen Native API
-Version:     0.28.7
+Version:     0.28.8
 Release:     0
 Group:       Multimedia/Framework
 License:     Apache-2.0 and BSD-3-Clause

diff --git a/test/testsuites/machine_learning/image_classification/test_image_classification.cpp b/test/testsuites/machine_learning/image_classification/test_image_classification.cpp
index 735e85d7de248ea410f2a0e89b9e48fd3cadb81d..cfc082a9881731fdfd0175950f4f1d1c78d04bf4 100644 (file)
--- a/test/testsuites/machine_learning/image_classification/test_image_classification.cpp
+++ b/test/testsuites/machine_learning/image_classification/test_image_classification.cpp
@@ -108,7 +108,7 @@ TEST(ImageClassificationTest, InferenceShouldBeOk)
        ret = ImageHelper::loadImageToSource(image_path.c_str(), mv_source);
        ASSERT_EQ(ret, MEDIA_VISION_ERROR_NONE);
 
-       for (auto model : test_models) {
+       for (const auto &model : test_models) {
                cout << "model name : " << model.model_file << endl;
 
                ret = mv_image_classification_create(&handle);

diff --git a/test/testsuites/machine_learning/object_detection/test_object_detection.cpp b/test/testsuites/machine_learning/object_detection/test_object_detection.cpp
index 08dd55079af24bef2c959eaf1cd12e99a2b0ee3d..a82e3d9cdc4b7e3e8c146ea901f7602175c96944 100644 (file)
--- a/test/testsuites/machine_learning/object_detection/test_object_detection.cpp
+++ b/test/testsuites/machine_learning/object_detection/test_object_detection.cpp
@@ -151,7 +151,7 @@ TEST(ObjectDetectionTest, InferenceShouldBeOk)
        ret = ImageHelper::loadImageToSource(IMG_DOG, mv_source);
        ASSERT_EQ(ret, MEDIA_VISION_ERROR_NONE);
 
-       for (auto model : test_models) {
+       for (const auto &model : test_models) {
                cout << "model name : " << model.model_file << endl;
 
                ret = mv_object_detection_create(&handle);
@@ -223,7 +223,7 @@ TEST(FaceDetectionTest, InferenceShouldBeOk)
        ret = ImageHelper::loadImageToSource(IMG_FACE, mv_source);
        ASSERT_EQ(ret, MEDIA_VISION_ERROR_NONE);
 
-       for (auto model : test_models) {
+       for (auto &model : test_models) {
                cout << "model name : " << model.model_file << endl;
 
                ret = mv_face_detection_create(&handle);

diff --git a/test/testsuites/machine_learning/object_detection_3d/test_object_detection_3d.cpp b/test/testsuites/machine_learning/object_detection_3d/test_object_detection_3d.cpp
index f73e9cdab1aa4707f35bc9c33dd90fbefdd231bd..d803e83b68df9de2bb2496bf17e7fe1ca244623a 100644 (file)
--- a/test/testsuites/machine_learning/object_detection_3d/test_object_detection_3d.cpp
+++ b/test/testsuites/machine_learning/object_detection_3d/test_object_detection_3d.cpp
@@ -100,7 +100,7 @@ TEST(ObjectDetection3dTest, InferenceShouldBeOk)
        ret = ImageHelper::loadImageToSource(image_path.c_str(), mv_source);
        ASSERT_EQ(ret, MEDIA_VISION_ERROR_NONE);
 
-       for (auto model : test_models) {
+       for (const auto &model : test_models) {
                mv_object_detection_3d_h handle;
 
                cout << "model name : " << model.model_file << endl;