drm/i915: handle faked missed interrupts as simulated hangs, too
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 28 Oct 2013 08:24:13 +0000 (09:24 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 30 Oct 2013 09:35:55 +0000 (10:35 +0100)
Otherwise QA will report this as a real hang when running igt
ZZ_missed_irq.

v2: Actually test the right stuff and really shut up the DRM_ERROR
output ...

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70747
Tested-by: lu hua <huax.lu@intel.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_irq.c

index 1a7dc77..68936da 100644 (file)
@@ -2258,8 +2258,12 @@ static void i915_hangcheck_elapsed(unsigned long data)
                                if (waitqueue_active(&ring->irq_queue)) {
                                        /* Issue a wake-up to catch stuck h/w. */
                                        if (!test_and_set_bit(ring->id, &dev_priv->gpu_error.missed_irq_rings)) {
-                                               DRM_ERROR("Hangcheck timer elapsed... %s idle\n",
-                                                         ring->name);
+                                               if (!(dev_priv->gpu_error.test_irq_rings & intel_ring_flag(ring)))
+                                                       DRM_ERROR("Hangcheck timer elapsed... %s idle\n",
+                                                                 ring->name);
+                                               else
+                                                       DRM_INFO("Fake missed irq on %s\n",
+                                                                ring->name);
                                                wake_up_all(&ring->irq_queue);
                                        }
                                        /* Safeguard against driver failure */