drm/i915/display: Use original src in psr2 sel fetch area calculation
authorJouni Högander <jouni.hogander@intel.com>
Tue, 23 Aug 2022 11:29:18 +0000 (14:29 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 13 Sep 2022 10:53:56 +0000 (13:53 +0300)
drm_plane_state->src is modified when offset is calculated:

before calculation:
src.x1 = 8192, src.y1 = 8192

after calculation (pitch = 65536, cpp = 4, alignment = 262144)
src.x1 = 8192, src.y1 = 0, offset = 0x20000000

Damage clips are relative to original coodrdinates provided by
user-space. To compare these against src coordinates we need to use
original coordinates as provided by user-space. These can be obtained
by using drm_plane_state_src.

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220823112920.352563-3-jouni.hogander@intel.com
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
drivers/gpu/drm/i915/display/intel_psr.c

index 90d7cdd..0d5a232 100644 (file)
@@ -1768,7 +1768,8 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
                        continue;
                }
 
-               drm_rect_fp_to_int(&src, &new_plane_state->uapi.src);
+               src = drm_plane_state_src(&new_plane_state->uapi);
+               drm_rect_fp_to_int(&src, &src);
 
                drm_atomic_helper_damage_iter_init(&iter,
                                                   &old_plane_state->uapi,