dm bufio: fix time comparison to use time_after_eq()
authorAsaf Vertz <asaf.vertz@tandemg.com>
Tue, 6 Jan 2015 13:44:15 +0000 (15:44 +0200)
committerMike Snitzer <snitzer@redhat.com>
Mon, 9 Feb 2015 18:06:48 +0000 (13:06 -0500)
To be future-proof and for better readability the time comparison
is modified to use time_after_eq() instead of plain, error-prone math.

Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-bufio.c

index c33b497..86dbbc7 100644 (file)
@@ -11,6 +11,7 @@
 #include <linux/device-mapper.h>
 #include <linux/dm-io.h>
 #include <linux/slab.h>
+#include <linux/jiffies.h>
 #include <linux/vmalloc.h>
 #include <linux/shrinker.h>
 #include <linux/module.h>
@@ -1739,7 +1740,7 @@ static unsigned get_max_age_hz(void)
 
 static bool older_than(struct dm_buffer *b, unsigned long age_hz)
 {
-       return (jiffies - b->last_accessed) >= age_hz;
+       return time_after_eq(jiffies, b->last_accessed + age_hz);
 }
 
 static void __evict_old_buffers(struct dm_bufio_client *c, unsigned long age_hz)