rtc: ds1343: clean up ds1343_nvram_read()/ds1343_nvram_write()
authorVladimir Zapolskiy <vz@mleia.com>
Sun, 26 Jul 2015 21:48:29 +0000 (00:48 +0300)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Sat, 5 Sep 2015 11:19:10 +0000 (13:19 +0200)
The change removes redundant sysfs binary file boundary checks, since
this task is already done on caller side in fs/sysfs/file.c

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-ds1343.c

index ae9f997..79a06dd 100644 (file)
@@ -162,12 +162,6 @@ static ssize_t ds1343_nvram_write(struct file *filp, struct kobject *kobj,
        struct device *dev = kobj_to_dev(kobj);
        struct ds1343_priv *priv = dev_get_drvdata(dev);
 
-       if (unlikely(!count))
-               return count;
-
-       if ((count + off) > DS1343_NVRAM_LEN)
-               count = DS1343_NVRAM_LEN - off;
-
        address = DS1343_NVRAM + off;
 
        ret = regmap_bulk_write(priv->map, address, buf, count);
@@ -187,12 +181,6 @@ static ssize_t ds1343_nvram_read(struct file *filp, struct kobject *kobj,
        struct device *dev = kobj_to_dev(kobj);
        struct ds1343_priv *priv = dev_get_drvdata(dev);
 
-       if (unlikely(!count))
-               return count;
-
-       if ((count + off) > DS1343_NVRAM_LEN)
-               count = DS1343_NVRAM_LEN - off;
-
        address = DS1343_NVRAM + off;
 
        ret = regmap_bulk_read(priv->map, address, buf, count);