sctp: remove the never used 'return' and redundant 'break'
authorwangweidong <wangweidong1@huawei.com>
Thu, 19 Dec 2013 02:02:42 +0000 (10:02 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 22 Dec 2013 23:56:51 +0000 (18:56 -0500)
In switch() had do return, and never use the 'return NULL'. The
'break' after return or goto has no effect. Remove it.

v2: make it more readable as suggested by Neil.

Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/input.c

index 2a192a7..e978235 100644 (file)
@@ -1116,19 +1116,10 @@ static struct sctp_association *__sctp_rcv_lookup_harder(struct net *net,
                return NULL;
 
        /* If this is INIT/INIT-ACK look inside the chunk too. */
-       switch (ch->type) {
-       case SCTP_CID_INIT:
-       case SCTP_CID_INIT_ACK:
+       if (ch->type == SCTP_CID_INIT || ch->type == SCTP_CID_INIT_ACK)
                return __sctp_rcv_init_lookup(net, skb, laddr, transportp);
-               break;
 
-       default:
-               return __sctp_rcv_walk_lookup(net, skb, laddr, transportp);
-               break;
-       }
-
-
-       return NULL;
+       return __sctp_rcv_walk_lookup(net, skb, laddr, transportp);
 }
 
 /* Lookup an association for an inbound skb. */