staging: typec: tcpm: Do not send PING msgs in TCPM

PING messages are used to monitor the connect/disconnect.
However, when PD is carried over CC, so this is not required.

Also, the spec does not clearly say if PD is possible when
Type-c is connected to Type-A/B. So, removing sending
PING messages altogether.

Signed-off-by: Badhri Jagan Sridharan <Badhri@google.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
index 36a7098..cbfb1a4 100644 (file)
--- a/drivers/staging/typec/tcpm.c
+++ b/drivers/staging/typec/tcpm.c
@@ -2340,14 +2340,11 @@ static void run_state_machine(struct tcpm_port *port)
                 * - The system is not operating in PD mode
                 * or
                 * - Both partners are connected using a Type-C connector
-                *   XXX How do we know that ?
+                *
+                * There is no actual need to send PD messages since the local
+                * port type-c and the spec does not clearly say whether PD is
+                * possible when type-c is connected to Type-A/B
                 */
-               if (port->pwr_opmode == TYPEC_PWR_MODE_PD &&
-                   !port->op_vsafe5v) {
-                       tcpm_pd_send_control(port, PD_CTRL_PING);
-                       tcpm_set_state_cond(port, SRC_READY,
-                                           PD_T_SOURCE_ACTIVITY);
-               }
                break;
        case SRC_WAIT_NEW_CAPABILITIES:
                /* Nothing to do... */