Ecore con socks: Add missing break statement to switch.
authorTom Hacohen <tom@stosb.com>
Tue, 8 Dec 2015 11:05:17 +0000 (11:05 +0000)
committerTom Hacohen <tom@stosb.com>
Tue, 8 Dec 2015 11:05:19 +0000 (11:05 +0000)
This looks like an obvious case of missing break. If it wasn't a missing
break, there should have been at least a comment. Looking at the code it
looks like a break is needed. Also, I suspect this code path is never
really tested, and that's why we never hit it.

Tests are not failing either way.

CID1039379

src/lib/ecore_con/ecore_con_socks.c

index e6226e3..a017f2b 100644 (file)
@@ -382,6 +382,7 @@ _ecore_con_socks_read_v5(Ecore_Con_Server *obj, Ecore_Con_Socks_v5 *v5, const un
            default:
              break;
           }
+        break;
 
       case ECORE_CON_PROXY_STATE_REQUEST:
       {