spi: atmel: Remove setting of deprecated member of struct dma_slave_config
authorTudor Ambarus <tudor.ambarus@microchip.com>
Thu, 25 Nov 2021 12:41:10 +0000 (14:41 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 26 Nov 2021 13:24:38 +0000 (13:24 +0000)
The 'direction' member of 'struct dma_slave_config' is deprecated.
Instead, drivers should use the direction argument to the
device_prep_slave_sg and device_prep_dma_cyclic functions or the
dir field in the dma_interleaved_template structure.
spi-atmel uses the direction argument to dmaengine_prep_slave_sg.
slave_config.direction is not used in neither of the DMA controller
drivers (at_h/xdmac) that spi-atmel is using, we can just remove the
setting of slave_config.direction and live with whatever stack value
is there.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Link: https://lore.kernel.org/r/20211125124110.838037-3-tudor.ambarus@microchip.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-atmel.c

index 22c7239..f6626be 100644 (file)
@@ -467,7 +467,6 @@ static int atmel_spi_dma_slave_config(struct atmel_spi *as, u8 bits_per_word)
         * So we'd rather write only one data at the time. Hence the transmit
         * path works the same whether FIFOs are available (and enabled) or not.
         */
-       slave_config.direction = DMA_MEM_TO_DEV;
        if (dmaengine_slave_config(master->dma_tx, &slave_config)) {
                dev_err(&as->pdev->dev,
                        "failed to configure tx dma channel\n");
@@ -482,7 +481,6 @@ static int atmel_spi_dma_slave_config(struct atmel_spi *as, u8 bits_per_word)
         * So the receive path works the same whether FIFOs are available (and
         * enabled) or not.
         */
-       slave_config.direction = DMA_DEV_TO_MEM;
        if (dmaengine_slave_config(master->dma_rx, &slave_config)) {
                dev_err(&as->pdev->dev,
                        "failed to configure rx dma channel\n");