drm/amdgpu: unlock on error in gfx_v9_4_3_kiq_resume()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 3 May 2023 15:09:35 +0000 (18:09 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 9 Jun 2023 13:32:27 +0000 (09:32 -0400)
Smatch complains that we need to drop this lock before returning.

    drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c:1838 gfx_v9_4_3_kiq_resume()
    warn: inconsistent returns 'ring->mqd_obj->tbo.base.resv'.

Fixes: 86301129698b ("drm/amdgpu: split gc v9_4_3 functionality from gc v9_0")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c

index b592454..c9ae306 100644 (file)
@@ -1824,8 +1824,10 @@ static int gfx_v9_4_3_kiq_resume(struct amdgpu_device *adev, int xcc_id)
                return r;
 
        r = amdgpu_bo_kmap(ring->mqd_obj, (void **)&ring->mqd_ptr);
-       if (unlikely(r != 0))
+       if (unlikely(r != 0)) {
+               amdgpu_bo_unreserve(ring->mqd_obj);
                return r;
+       }
 
        gfx_v9_4_3_kiq_init_queue(ring, xcc_id);
        amdgpu_bo_kunmap(ring->mqd_obj);